Re: [Patch 0/5] Add exclusions for tests requiring cvs where cvs is not installed

From: Jeff King <peff@peff.net>
Date: Jun 13, 2019, 19:06 UTC
Message-ID: <20190613190644.GC27217@sigill.intra.peff.net>
In-Reply-To: <20190613185313.16120-1-randall.s.becker@rogers.com>

On Thu, Jun 13, 2019 at 02:53:08PM -0400, randall.s.becker@rogers.com wrote:

Show 7 quoted lines

> From: "Randall S. Becker" <rsbecker@nexbridge.com>
> 
> t9600 to t9604 currently depend on cvs to function correctly, otherwise
> all of those tests fail. This patch follows an existing pattern of
> from the t9400 series by attempting to run cvs without arguments,
> which succeeds if installed, and skipping the test if the command
> fails.

Hrm. I don't have cvs installed, and those tests are properly skipped for me. That's because they include lib-cvs.sh, which has:

  if ! type cvs >/dev/null 2>&1
  then
          skip_all='skipping cvsimport tests, cvs not found'
          test_done
  fi

Why doesn't that work for you? Does the "type" check not work (e.g., you have something called "cvs" but it does not behave as we expect)? If so, then it sounds like we just need to harmonize that with the other checks.

It also sounds like the t9400 tests could be using lib-cvs to avoid duplicating logic, though it might need some refactoring (they don't need cvsps, for example).

-Peff