[PATCH v2 0/3] Test oidmap
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Jun 11, 2019, 08:23 UTC
- Message-ID
- <20190611082325.28878-1-chriscool@tuxfamily.org>
Unlike hashmap that has t/helper/test-hashmap.c and t/t0011-hashmap.sh oidmap has no specific test. The goal of this small patch series is to change that and also improve oidmap a bit while at it.
Changes compared to V1 are the following:
- use printf("%x\n", ntohl(sha1hash(oid.hash))) to print hashes as
suggested by Gábor and approved by Junio, - use `git rev-parse "$1" | cut -c1-8` to check hashes in t0016 as
suggested by Gábor, - removed PERL prereq on "hash" test in t0016 as allowed by the
above change and suggested by Gábor, - removed suprious space between ">" and "expect" in t0016 as
suggested by Gábor.I decided against hardcoding values as I think it might help transitionning from SHA1 to SHA256.
Christian Couder (3): t/helper: add test-oidmap.c t: add t0016-oidmap.sh oidmap: use sha1hash() instead of static hash() function
Makefile | 1 + oidmap.c | 13 +--- t/helper/test-oidmap.c | 134 +++++++++++++++++++++++++++++++++++++++++ t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t0016-oidmap.sh | 100 ++++++++++++++++++++++++++++++ 6 files changed, 240 insertions(+), 10 deletions(-) create mode 100644 t/helper/test-oidmap.c create mode 100755 t/t0016-oidmap.sh
-- 2.22.0.6.gde8b105b43