git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/3] Test oidmap

From
Christian Couder <christian.couder@gmail.com>
Date
Jun 11, 2019, 08:23 UTC
Message-ID
<20190611082325.28878-1-chriscool@tuxfamily.org>

Unlike hashmap that has t/helper/test-hashmap.c and t/t0011-hashmap.sh oidmap has no specific test. The goal of this small patch series is to change that and also improve oidmap a bit while at it.

Changes compared to V1 are the following:
  - use printf("%x\n", ntohl(sha1hash(oid.hash))) to print hashes as
    suggested by Gábor and approved by Junio,
  - use `git rev-parse "$1" | cut -c1-8` to check hashes in t0016 as
    suggested by Gábor,
  - removed PERL prereq on "hash" test in t0016 as allowed by the
    above change and suggested by Gábor,
  - removed suprious space between ">" and "expect" in t0016 as
    suggested by Gábor.

I decided against hardcoding values as I think it might help transitionning from SHA1 to SHA256.

Christian Couder (3):
  t/helper: add test-oidmap.c
  t: add t0016-oidmap.sh
  oidmap: use sha1hash() instead of static hash() function
 Makefile               |   1 +
 oidmap.c               |  13 +---
 t/helper/test-oidmap.c | 134 +++++++++++++++++++++++++++++++++++++++++
 t/helper/test-tool.c   |   1 +
 t/helper/test-tool.h   |   1 +
 t/t0016-oidmap.sh      | 100 ++++++++++++++++++++++++++++++
 6 files changed, 240 insertions(+), 10 deletions(-)
 create mode 100644 t/helper/test-oidmap.c
 create mode 100755 t/t0016-oidmap.sh
-- 
2.22.0.6.gde8b105b43
Next: Christian Couder
Message 1 of 7 in “Test oidmap”
  1. 0/3 Test oidmapChristian Couder, Jun 11, 2019
  2. 1/3 t/helper: add test-oidmap.cChristian Couder, Jun 11, 2019
  3. 2/3 t: add t0016-oidmap.shChristian Couder, Jun 11, 2019
  4. SZEDER GáborJun 11, 2019
  5. Christian CouderJun 12, 2019
  6. 3/3 oidmap: use sha1hash() instead of static hash() functionChristian Couder, Jun 11, 2019
  7. SZEDER GáborJun 11, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.