[PATCH 1/1] list-objects-filter-options: error is localizeable
- From
Matthew DeVore <matvore@google.com>
- Date
- May 31, 2019, 18:01 UTC
- Message-ID
- <20190531180156.GA7633@comcast.net>
The "invalid filter-spec" message is user-facing and not a BUG, so make it localizeable.
For reference, the message appears in this context:
$ git rev-list --filter=blob:nonse --objects HEAD fatal: invalid filter-spec 'blob:nonse'
Signed-off-by: Matthew DeVore <matvore@google.com> --- list-objects-filter-options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/list-objects-filter-options.c b/list-objects-filter-options.c index c0036f7378..e46ea467bc 100644 --- a/list-objects-filter-options.c +++ b/list-objects-filter-options.c @@ -81,21 +81,21 @@ static int gently_parse_list_objects_filter( filter_options->choice = LOFC_SPARSE_PATH; filter_options->sparse_path_value = strdup(v0); return 0; } /* * Please update _git_fetch() in git-completion.bash when you * add new filters */ if (errbuf) - strbuf_addf(errbuf, "invalid filter-spec '%s'", arg); + strbuf_addf(errbuf, _("invalid filter-spec '%s'"), arg); memset(filter_options, 0, sizeof(*filter_options)); return 1; } int parse_list_objects_filter(struct list_objects_filter_options *filter_options, const char *arg) { struct strbuf buf = STRBUF_INIT; if (gently_parse_list_objects_filter(filter_options, arg, &buf))
-- 2.17.1