Re: [PATCH] send-email: remove documented requirement for Net::SMTP::SSL
- From
- Eric Wong <e@80x24.org>
- Date
- May 27, 2019, 19:35 UTC
- Message-ID
- <20190527193517.GA22013@dcvr>
- In-Reply-To
- <20190526172242.13000-1-aklhfex@gmail.com>
Chris Mayo <aklhfex@gmail.com> wrote:
Show 6 quoted lines
> git-send-email uses the TLS support in the Net::SMTP core module from
> recent versions of Perl. Documenting the minimum version is complex
> because of separate numbering for Perl (5.21.5~169), Net:SMTP (2.34)
> and libnet (3.01). Version numbers from commit:
> bfbfc9a953 ("send-email: Net::SMTP::starttls was introduced in v2.34",
> 2017-05-31)No disagreement for removing the doc requirement for Net::SMTP::SSL.
But core modules can be split out by OS packagers. For Fedora/RH-based systems, the trend tends to be increasing granularity and having more optional packages.
So I think documenting Net::SMTP (and Net::Domain) as requirements would still be good, perhaps with a note stating they're typically installed with Perl.
Fwiw, I recently ran into some issues where core modules such as Devel::Peek, Encode, and autodie were separate packages on CentOS 7.