git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] revision: keep topo-walk free of unintersting commits

From
Mike Hommey <mh@glandium.org>
Date
May 22, 2019, 02:19 UTC
Message-ID
<20190522021928.tsmg2rij6l44xvdj@glandium.org>
In-Reply-To
<20190521135953.214701-1-dstolee@microsoft.com>
On Tue, May 21, 2019 at 09:59:53AM -0400, Derrick Stolee wrote:
Show 25 quoted lines
> When updating the topo-order walk in b454241 (revision.c: generation-based
> topo-order algorithm, 2018-11-01), the logic was a huge rewrite of the
> walk logic. In that massive change, we accidentally included the
> UNINTERESTING commits in expand_topo_walk(). This means that a simple
> query like
> 
>     git rev-list --topo-order HEAD~1..HEAD
> 
> will expand the topo walk for all commits reachable from HEAD, and not
> just one commit.
> 
> This change should speed up these cases, but there is still a need
> for corrected commit-date for some A..B queries.
> 
> Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
> ---
> 
> Sorry for the patch-spam, but I took a moment to check this command
> on the Git repo, and was able to reproduce the slowness. That didn't
> make sense to me, so I added some log messages to expand_topo_walk()
> and notices we were walking the UNINITERESTING commits. This is part
> of the reason the new logic is slower for A..B commands, but not the
> whole reason.
> 
> You'll want this patch as well for a test.
Both patches help, thanks.
Mike
Previous: Derrick StoleeNext: Jonathan Nieder
Message 22 of 23 in “Revision walking, commit dates, slop”
  1. Mike HommeyMay 18, 2019
  2. SZEDER GáborMay 18, 2019
  3. Mike HommeyMay 18, 2019
  4. Mike HommeyMay 18, 2019
  5. SZEDER GáborMay 18, 2019
  6. Jakub NarebskiMay 19, 2019
  7. Derrick StoleeMay 20, 2019
  8. Jakub NarebskiMay 20, 2019
  9. Derrick StoleeMay 20, 2019
  10. Jakub NarebskiMay 20, 2019
  11. Jakub NarebskiMay 20, 2019
  12. Derrick StoleeMay 21, 2019
  13. Jakub NarebskiMay 22, 2019
  14. Derrick StoleeMay 22, 2019
  15. Jakub NarebskiMay 23, 2019
  16. Jakub NarebskiJun 25, 2019
  17. Derrick StoleeJun 25, 2019
  18. commit-graph: generation v5 (backward compatible date ceiling)Jakub Narebski, Sep 18, 2019
  19. Derrick StoleeSep 18, 2019
  20. revision: use generation for A..B --topo-order queriesDerrick Stolee, May 21, 2019
  21. 2/2 revision: keep topo-walk free of unintersting commitsDerrick Stolee, May 21, 2019
  22. Mike HommeyMay 22, 2019
  23. Jonathan NiederMay 21, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.