git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] Use xmmap_gently instead of xmmap in use_pack

From
Mike Hommey <mh@glandium.org>
Date
May 16, 2019, 00:37 UTC
Message-ID
<20190516003736.25544-2-mh@glandium.org>
In-Reply-To
<20190516003736.25544-1-mh@glandium.org>

use_pack has its own error message on mmap error, but it can't be reached when using xmmap, which dies with its own error.

Signed-off-by: Mike Hommey <mh@glandium.org>
---
 packfile.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/packfile.c b/packfile.c
index 16bcb75262..6a66b605e9 100644
--- a/packfile.c
+++ b/packfile.c
@@ -630,7 +630,7 @@ unsigned char *use_pack(struct packed_git *p,
 			while (packed_git_limit < pack_mapped
 				&& unuse_one_window(p))
 				; /* nothing */
-			win->base = xmmap(NULL, win->len,
+			win->base = xmmap_gently(NULL, win->len,
 				PROT_READ, MAP_PRIVATE,
 				p->pack_fd, win->offset);
 			if (win->base == MAP_FAILED)
-- 
2.21.0.dirty
Previous: Mike HommeyNext: Jeff King
Message 3 of 5 in “Re: Closing fds twice when using remote helpers”
  1. Mike HommeyMay 16, 2019
  2. 1/2 dup() the input fd for fast-import used for remote helpersMike Hommey, May 16, 2019
  3. 2/2 Use xmmap_gently instead of xmmap in use_packMike Hommey, May 16, 2019
  4. Jeff KingMay 16, 2019
  5. Jeff KingMay 16, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.