Re: [WIP] repack leaving stale entries in objects/info/packs

From: Jeff King <peff@peff.net>
Date: May 15, 2019, 21:48 UTC
Message-ID: <20190515214806.GA31693@sigill.intra.peff.net>
In-Reply-To: <20190515203839.zixx23bwzeyto6a3@dcvr>

On Wed, May 15, 2019 at 08:38:39PM +0000, Eric Wong wrote:

Show 6 quoted lines

> I've also noticed objects/info/packs contains stale entries
> after repack/gc runs on current git.
> 
> Tried adding reprepare_packed_git before update_server_info,
> but that didn't seem to work; so maybe something isn't cleared.
> Might have time to investigate more this week, might not...

We never delete entries from the in-memory packed_git list; a reprepare only adds to the list. You'd need to teach update_server_info() to ignore packs which are no longer present (or switch to exec-ing a separate update-server-info binary).

-Peff