git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: allow a differn't diff.context config for git format-patch

From
Jeff King <peff@peff.net>
Date
May 14, 2019, 09:57 UTC
Message-ID
<20190514095722.GA12580@sigill.intra.peff.net>
In-Reply-To
<20190514095446.GA12299@sigill.intra.peff.net>
On Tue, May 14, 2019 at 05:54:46AM -0400, Jeff King wrote:
Show 20 quoted lines
> On Sun, May 12, 2019 at 07:29:42AM -0500, Shawn Landden wrote:
> 
> > > After init_revisions(), we'll have called diff_setup(), which puts
> > > diff_context_default into revs->diffopt. So we still have to do the "if
> > > we have a format-specific value, then override..." conditional. But we
> > > can do it without touching the hidden variable:
> > >
> > Looks like this fell into the cracks. You guys know the code much better
> > than me, but do I have to write a patch to make this happen?
> 
> I think there is more work to be done in actually parsing such a config
> option, plus adding documentation and tests.
> 
> But more importantly, it needs somebody to champion the feature. I don't
> find it an unreasonable thing to want. But I'm not personally
> interested, nor am I completely sure that it wouldn't have any unwanted
> side effects.
> 
> So ideally somebody would write the patch and a compelling commit
> message that explains why it is a good idea.

By the way, if you (or anybody) is interested, looking at how signoff is implemented (try "git grep -i format.signoff") should get you most of the way there.

-Peff
Previous: Jeff King
Message 7 of 7 in “allow a differn't diff.context config for git format-patch”
  1. Shawn LanddenApr 14, 2019
  2. Jeff KingApr 23, 2019
  3. Junio C HamanoApr 23, 2019
  4. Jeff KingApr 23, 2019
  5. Shawn LanddenMay 12, 2019
  6. Jeff KingMay 14, 2019
  7. Jeff KingMay 14, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.