Re: [PATCH 2/2] diffcore-pickaxe: add --pickaxe-raw-diff for use with -G

From: Eugeniu Rosca <erosca@de.adit-jv.com>
Date: May 3, 2019, 09:10 UTC
Message-ID: <20190503091049.GA6438@vmlxhi-102.adit-jv.com>
In-Reply-To: <87ftq6s252.fsf@evledraar.gmail.com>

On Thu, Apr 25, 2019 at 02:25:13PM +0200, Ævar Arnfjörð Bjarmason wrote: [..]

Show 7 quoted lines

> Do you or anyone have a suggestion for a better CLI option name?
> 
> Maybe --pickaxe-patch or --pickaxe-patch-format (to go with git-diff's
> -u aka --patch (i.e. not --raw) default format)? Or
> --pickaxe-G-with-context or --pickaxe-with-context or
> --with-pickaxe-context or --pickaxe-context ? All of these suck, but I'm
> coming up blank on a better one :)

'--pickaxe-patch' is shorter than '--pickaxe-raw-diff', hence more convenient to me. It looks like 'pickaxe-all' and 'pickaxe-regex' are the only --pickaxe-* options currently implemented. Both of them are two-worded only and easy to remember/type. I think '--pickaxe-patch' is more user-friendly, but I leave git people to say the final word.

Show 8 quoted lines

> 
> Probably the least shitty of those shitty options is --pickaxe-patch,
> since we have --patch which triggers the same format, and we can
> document that the default is a -G search through --no-pickaxe-patch, and
> you can just tweak the format.
> 
> It also leaves the door open (unlike having *-G-* in the option) to
> support this for -S if anyone cared...

-- 
Best Regards,
Eugeniu.