Re: [PATCH] p5302: create the repo in each index-pack test

From: Jeff King <peff@peff.net>
Date: Apr 23, 2019, 02:36 UTC
Message-ID: <20190423023651.GD16369@sigill.intra.peff.net>
In-Reply-To: <xmqqv9z55udl.fsf@gitster-ct.c.googlers.com>

On Tue, Apr 23, 2019 at 11:27:02AM +0900, Junio C Hamano wrote:

Show 16 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> >> This is obviously inherited from the original, but do we get scolded
> >> by some versions of bash for this line, without quoting the source path
> >> of the redirection, i.e.
> >> 
> >> 	... --stdin <"$PACK"
> >
> > In general, yes, but I think we are OK in this instance because we
> > generated $PACK ourselves in the setup step, and we know that it is just
> > a relative .git/objects/pack/xyz.pack with no spaces.
> 
> I know we are OK, but the issue with some versions of bash AFAIU is
> that bash is not OK regardless of the contents of $variable that is
> not quoted and used as the target or the source of a redirection,
> issuing an unnecessary warning.

Is it? I thought the issue was specifically when there were spaces. I get:

  $ bash
  $ file=ok
  $ echo foo >$file
  $ file='not ok'
  $ echo foo >$file
  bash: $file: ambiguous redirect

And that is AFAIK what the recent 7951a016a5 (t4038-diff-combined: quote paths with whitespace, 2019-03-17) was about (because our trash directory always has a space in it).

Did I miss a report where it happens on some versions even without spaces? If so, we have quite a number of things to fix judging from the output of:

  git grep '>\$'

-Peff