git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t5516: fix mismerge in 'next'

From
Jeff King <peff@peff.net>
Date
Apr 22, 2019, 04:48 UTC
Message-ID
<20190422044812.GA28493@sigill.intra.peff.net>

The merge of jk/fetch-reachability-error-fix conflicts with jt/test-protocol-version, but the conflict resolution done by b4ce8375c018 has a typo (looks like an editor mistake):

  $ git show b4ce8375c018
  [...]
   -                      test_must_fail git fetch ../testrepo/.git $SHA1_3 &&
   -                      test_must_fail git fetch ../testrepo/.git $SHA1_1 &&
   +                      # Some protocol versions (e.g. 2) support fetching
   +                      # unadvertised objects, so restrict this test to v0.
  -                       test_must_fail ok=sigpipe env GIT_TEST_PROTOCOL_VERSION= \
  -                               git fetch ../testrepo/.git $SHA1_3 &&
  -                       test_must_fail ok=sigpipe env GIT_TEST_PROTOCOL_VERSION= \
  ++                      test_must_fail env GIT_TEST_PROTOCOL_VERSION= \
  ++                              git fetepo/.git $SHA1_3 &&
  ++                      test_must_fail env GIT_TEST_PROTOCOL_VERSION= \
   +                              git fetch ../testrepo/.git $SHA1_1 &&

The tests don't notice the bogus command because we expect the command to fail.

Signed-off-by: Jeff King <peff@peff.net>
---
The same problem is present in the merges to pu, which is not surprising
since the 'next' merge was probably just resolved by rerere. We'd
presumably want a fixup like this for 'next' until the next rewind, but
the more important thing is to adjust the rerere cache so the eventual
merge to 'master' is correct.
 t/t5516-fetch-push.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh
index 09e7178987..c81ca360ac 100755
--- a/t/t5516-fetch-push.sh
+++ b/t/t5516-fetch-push.sh
@@ -1242,7 +1242,7 @@ do
 			# Some protocol versions (e.g. 2) support fetching
 			# unadvertised objects, so restrict this test to v0.
 			test_must_fail env GIT_TEST_PROTOCOL_VERSION= \
-				git fetepo/.git $SHA1_3 &&
+				git fetch ../testrepo/.git $SHA1_3 &&
 			test_must_fail env GIT_TEST_PROTOCOL_VERSION= \
 				git fetch ../testrepo/.git $SHA1_1 &&
 			git --git-dir=../testrepo/.git config uploadpack.allowreachablesha1inwant true &&
-- 
2.21.0.1179.g65a7c4fda7
Next: Junio C Hamano
Message 1 of 2 in “t5516: fix mismerge in 'next'”
  1. t5516: fix mismerge in 'next'Jeff King, Apr 22, 2019
  2. Junio C HamanoApr 22, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.