git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/7] some fetch reachability-error fixes

From
Jeff King <peff@peff.net>
Date
Apr 13, 2019, 05:51 UTC
Message-ID
<20190413055127.GA32340@sigill.intra.peff.net>

This series fixes a few minor bugs around clients trying to fetch unreachable commits, along with a few associated cleanups.

There's a minor conflict in t5516 when merging with next, since that adds GIT_TEST_PROTOCOL_VERSION, causing a few textual conflicts. The resolution should be fairly clear.

Where appropriate, I took GIT_TEST_PROTOCOL_VERSION into account so that after merging with next, all tests should still pass even with it set to "2" (well, all the tests that do not already fail on vanilla 'next' with that setting).

  [1/7]: t5516: drop ok=sigpipe from unreachable-want tests
  [2/7]: t5530: check protocol response for "not our ref"
  [3/7]: upload-pack: send ERR packet for non-tip objects
  [4/7]: pkt-line: prepare buffer before handling ERR packets
  [5/7]: fetch: use free_refs()
  [6/7]: remote.c: make singular free_ref() public
  [7/7]: fetch: do not consider peeled tags as advertised tips
 fetch-pack.c                 | 16 +++++++++-------
 pkt-line.c                   |  9 +++++----
 remote.c                     |  6 +++---
 remote.h                     |  4 +++-
 t/t5516-fetch-push.sh        | 18 +++++++++++++++---
 t/t5530-upload-pack-error.sh | 18 +++++++++++++++---
 upload-pack.c                | 11 ++++++++---
 7 files changed, 58 insertions(+), 24 deletions(-)
-Peff
Next: Jeff King
Message 1 of 9 in “some fetch reachability-error fixes”
  1. 0/7 some fetch reachability-error fixesJeff King, Apr 13, 2019
  2. 1/7 t5516: drop ok=sigpipe from unreachable-want testsJeff King, Apr 13, 2019
  3. 2/7 t5530: check protocol response for "not our ref"Jeff King, Apr 13, 2019
  4. 3/7 upload-pack: send ERR packet for non-tip objectsJeff King, Apr 13, 2019
  5. 4/7 pkt-line: prepare buffer before handling ERR packetsJeff King, Apr 13, 2019
  6. 5/7 fetch: use free_refs()Jeff King, Apr 13, 2019
  7. 6/7 remote.c: make singular free_ref() publicJeff King, Apr 13, 2019
  8. 7/7 fetch: do not consider peeled tags as advertised tipsJeff King, Apr 13, 2019
  9. Jonathan TanApr 15, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.