Re: [PATCH 4/4] trace2: use system config for default trace2 settings
- From
Josh Steadmon <steadmon@google.com>
- Date
- Mar 28, 2019, 21:28 UTC
- Message-ID
- <20190328212814.GB60888@google.com>
- In-Reply-To
- <7e0d4e20fbb3abbc787bc216d2c4bd8c18860aed.1553779851.git.gitgitgadget@gmail.com>
One quick comment:
On 2019.03.28 06:31, Jeff Hostetler via GitGitGadget wrote: [...]
Show 25 quoted lines
> diff --git a/trace2.h b/trace2.h > index 8f89e70c44..cda8349058 100644 > --- a/trace2.h > +++ b/trace2.h > @@ -38,7 +38,8 @@ void trace2_initialize_clock(void); > > /* > * Initialize TRACE2 tracing facility if any of the builtin TRACE2 > - * targets are enabled in the environment. Emits a 'version' event. > + * targets are enabled in the system config or the environment. > + * Emits a 'version' event. > * > * Cleanup/Termination is handled automatically by a registered > * atexit() routine. > @@ -125,8 +126,8 @@ void trace2_cmd_alias_fl(const char *file, int line, const char *alias, > * Emit one or more 'def_param' events for "interesting" configuration > * settings. > * > - * The environment variable "GIT_TR2_CONFIG_PARAMS" can be set to a > - * list of patterns considered important. For example: > + * Use the TR2_SYSENV_CFG_PARAM setting to register a list of patterns > + * configured important. For example: > * > * GIT_TR2_CONFIG_PARAMS="core.*,remote.*.url" > *
Looks like the example needs to be updated with the new var name as well.