Re: [PATCH v3] glossary: add definition for overlay

From: Thomas Gummerer <t.gummerer@gmail.com>
Date: Mar 28, 2019, 21:05 UTC
Message-ID: <20190328210500.GH32487@hank.intra.tgummerer.com>
In-Reply-To: <xmqqbm23qzj8.fsf@gitster-ct.c.googlers.com>

On 03/22, Junio C Hamano wrote:

Show 8 quoted lines

> Philip Oakley <philipoakley@iee.org> writes:
> 
> >> of 'cp -R'.  I thought of making the same clarification for 'rsync
> >> --delete' as well, however I think with it being explicitly specified
> >> for 'cp -R', readers should be able to deduce that we are talking
> >> about the destination directory there as well.
> > As a historically Windows user, we should ensure that the meaning is
> > clear to all without the otherwise helpful *nix command examples.

Sure, it would definitely be good to be clear to users of all platforms. Is the text by itself not understandable enough? If not do you have any suggestions to improve it?

I think giving the example of 'cp -R' is still good, even if not all Windows users are familiar with it, as it's supposed to provide some additional context. But it's only an additional example, the sentence is supposed to be understandable either way. Would there be a similar command for Windows that could be used as an example?

Show 11 quoted lines

> I do not know about "cp -R", but surely "rsync" is used by Windows
> users as well as users of Unix based systems, isn't it?
> 
> >> +	Only update and add files to the working directory, but don't
> >> +	delete them, similar to how 'cp -R' would update the contents
> 
> > perhaps  s/them/any files/
> 
> Probably.  The paths that are not deleted are certainly different
> set of paths from those that are updated and/or added, so it sounds
> like a reasonable thing to do.

Thanks, will update this.

Show 22 quoted lines

> >> +	in the destination directory.  This is the default mode in a
> >> +	<<def_checkout,checkout>> when checking out files from the
> >> +	<<def_index,index>> or a <<def_tree-ish,tree-ish>>.  In
> >> +	contrast, no-overlay mode also deletes tracked files not
> >
> > understanding the past/future distinction is tricky here. Maybe
> > 'deletes previously tracked files that are no longer present in the
> > new source'.
> >
> > It's tricky talking about deleting things that are not there.
> 
> I am afraid that "previously" may be taken too literally by readers
> and misunderstood as paths that had been tracked even once in the
> past.  
> 
> If you think that is worried too much because we can only delete
> what is _currently_ in the index, and any past before what is in the
> current index cannot ever affect the outcome, the same reasoning
> tells me that the original is clear enough without "previously",
> i.e. "tracked ones not present in..." are the ones that are in the
> index currently, but the tree that we are taking new contents from
> does not have them.

Agreed, I think I prefer the current version over the suggested change here too.

> I dunno.
> 
> >> +	present in the source, similar to 'rsync --delete'.