Re: [PATCH 2/4] gc docs: include the "gc.*" section from "config" in "gc"
- From
Jeff King <peff@peff.net>
- Date
- Mar 18, 2019, 21:31 UTC
- Message-ID
- <20190318213139.GF29661@sigill.intra.peff.net>
- In-Reply-To
- <20190318161502.7979-3-avarab@gmail.com>
On Mon, Mar 18, 2019 at 05:15:00PM +0100, Ævar Arnfjörð Bjarmason wrote:
Show 8 quoted lines
> Rather than duplicating the documentation for the various "gc" options > let's include the "gc" docs from git-config. They were mostly better > already, and now we don't have the same docs in two places with subtly > different wording. > > In the cases where the git-gc(1) docs were saying something the "gc" > docs in git-config(1) didn't cover move the relevant section over to > the git-config(1) docs.
Makes sense.
I think we lose the actual example for gc.*.reflogExpire:
Show 9 quoted lines
> -The above two configuration variables can be given to a pattern. For > -example, this sets non-default expiry values only to remote-tracking > -branches: > - > ------------- > -[gc "refs/remotes/*"] > - reflogExpire = never > - reflogExpireUnreachable = 3 days > -------------
I don't actually think it's that big a loss. If we wanted to retain it, though, it might make sense in the "EXAMPLES" section.
-Peff