[PATCH v2 1/4] git: read local config in --list-cmds

From: Todd Zullinger <tmz@pobox.com>
Date: Mar 17, 2019, 18:16 UTC
Message-ID: <20190317181620.26727-2-tmz@pobox.com>
In-Reply-To: <CACsJy8BuR=syjT1gjTxXXKKaevzpbdRGp+je+rsX6jV96F3sbA@mail.gmail.com>

From: Jeff King <peff@peff.net>

Normally code that is checking config before we've decided to do setup_git_directory() would use read_early_config(), which uses discover_git_directory() to tentatively see if we're in a repo, and if so to add it to the config sequence.

But list_cmds() uses the caching configset mechanism which rightly does not use read_early_config(), because it has no idea if it's being called early.

Call setup_git_directory_gently() so we can pick up repo-level config (like completion.commands).

Signed-off-by: Jeff King <peff@peff.net>
---
 git.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/git.c b/git.c
index 2dd588674f..10e49d79f6 100644
--- a/git.c
+++ b/git.c
@@ -62,6 +62,13 @@ static int list_cmds(const char *spec)
 {
 	struct string_list list = STRING_LIST_INIT_DUP;
 	int i;
+	int nongit;
+
+	/*
+	* Set up the repository so we can pick up any repo-level config (like
+	* completion.commands).
+	*/
+	setup_git_directory_gently(&nongit);
 
 	while (*spec) {
 		const char *sep = strchrnul(spec, ',');