git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] Fix refs/rewritten not show up in for-each-ref

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Mar 7, 2019, 12:29 UTC
Message-ID
<20190307122917.12811-1-pclouds@gmail.com>
In-Reply-To
<ec707cbb-96e8-f26f-3d69-b69d29b31737@gmail.com>

Apparently there is one corner case where refs/rewritten/* may not show up in for-each-ref in multiple worktree setup. This is because the per-worktree classification has to be done in three places (my bad!) and Johannes only updated one.

This should fix it (and it also fixes refs/worktree/ not showing up under the same condition because I'm an idiot who does not know how to test).

Nguyễn Thái Ngọc Duy (3):
  files-backend.c: factor out per-worktree code in loose_fill_ref_dir()
  files-backend.c: reduce duplication in
    add_per_worktree_entries_to_dir()
  Make sure refs/rewritten/ is per-worktree
 path.c                   |  3 +++
 refs/files-backend.c     | 50 ++++++++++++++++++++++------------------
 t/t1415-worktree-refs.sh | 35 ++++++++++++++++++++++++++++
 3 files changed, 66 insertions(+), 22 deletions(-)
-- 
2.21.0.rc1.337.gdf7f8d0522
Previous: Duy NguyenNext: Nguyễn Thái Ngọc Duy
Message 5 of 11 in “[BUG] worktree local refs weirdness”
  1. Phillip WoodMar 6, 2019
  2. Phillip WoodMar 7, 2019
  3. Duy NguyenMar 7, 2019
  4. Duy NguyenMar 7, 2019
  5. 0/3 Fix refs/rewritten not show up in for-each-refNguyễn Thái Ngọc Duy, Mar 7, 2019
  6. 1/3 files-backend.c: factor out per-worktree code in loose_fill_ref_dir()Nguyễn Thái Ngọc Duy, Mar 7, 2019
  7. 2/3 files-backend.c: reduce duplication in add_per_worktree_entries_to_dir()Nguyễn Thái Ngọc Duy, Mar 7, 2019
  8. Phillip WoodMar 7, 2019
  9. 3/3 Make sure refs/rewritten/ is per-worktreeNguyễn Thái Ngọc Duy, Mar 7, 2019
  10. Phillip WoodMar 7, 2019
  11. Duy NguyenMar 7, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.