Re: [PATCH] builtin/config.c: don't print a newline with --color

From: Taylor Blau <me@ttaylorr.com>
Date: Mar 6, 2019, 23:44 UTC
Message-ID: <20190306234449.GF27082@Taylors-MBP.hsd1.wa.comcast.net>
In-Reply-To: <nycvar.QRO.7.76.6.1903022123160.45@tvgsbejvaqbjf.bet>

Hi Johannes,

On Sat, Mar 02, 2019 at 09:25:28PM +0100, Johannes Schindelin wrote:

Show 22 quoted lines

> Hi Taylor,
>
> On Fri, 1 Mar 2019, Taylor Blau wrote:
>
> > [ ... ]
>
> This should do the right thing if you write
>
> 	printf "<RED>" >expect
>
> instead?
>
> Ciao,
> Dscho
>
> > +	printf "\\033[31m" >expect &&
> > +	git config --get --type=color foo.color >actual &&
> >  	test_cmp expect actual
> >  '
> >
> > --
> > 2.20.1

Thank you for your suggestion. It occurred to me that this might be a preferable way to do things[1] after I sent the patch, but I am glad that you suggested it here explicitly.

That said, I think that this patch has moved on from the code change, after some discussion between Junio and Peff, so I think that I will leave this (and the rest of the code changes) behind.

Thanks, Taylor

[1] ... preferable in the way that we don't have to write "\\033[31m" in
    the test.