git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/2] doc/fsck: clarify --connectivity-only behavior

From
Jeff King <peff@peff.net>
Date
Mar 5, 2019, 04:46 UTC
Message-ID
<20190305044637.GA32325@sigill.intra.peff.net>
In-Reply-To
<20190305044530.GG19800@sigill.intra.peff.net>

On reading this again, there are two things that were not immediately clear to me:

  - we do still check links to blobs, even though we don't open the
    blobs themselves
  - we do not do the normal fsck checks, even for non-blob objects we do
    open
Let's reword it to make these points a little more clear.
Signed-off-by: Jeff King <peff@peff.net>
---
 Documentation/git-fsck.txt | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/Documentation/git-fsck.txt b/Documentation/git-fsck.txt
index 55950d9eea..b7c7ac0866 100644
--- a/Documentation/git-fsck.txt
+++ b/Documentation/git-fsck.txt
@@ -62,9 +62,13 @@ index file, all SHA-1 references in `refs` namespace, and all reflogs
 	with --no-full.
 
 --connectivity-only::
-	Check only the connectivity of tags, commits and tree objects. By
-	avoiding to unpack blobs, this speeds up the operation, at the
-	expense of missing corrupt objects or other problematic issues.
+	Check only the connectivity of reachable objects, making sure
+	that any objects referenced by a reachable tag, commit, or tree
+	is present. This speeds up the operation by avoiding reading
+	blobs entirely (though it does still check that referenced blobs
+	exist). This will detect corruption in commits and trees, but
+	not do any semantic checks (e.g., for format errors). Corruption
+	in blob objects will not be detected at all.
 
 --strict::
 	Enable more strict checking, namely to catch a file mode
-- 
2.21.0.684.gc9dc8b89c9
Previous: Jeff KingNext: Jeff King
Message 6 of 7 in “doc/fsck: discuss mix of --connectivity-only and --dangling”
  1. doc/fsck: discuss mix of --connectivity-only and --danglingJeff King, Feb 27, 2019
  2. Jeff KingFeb 27, 2019
  3. Junio C HamanoMar 1, 2019
  4. Jeff KingMar 5, 2019
  5. 0/2 fsck --connectivity-only --danglingJeff King, Mar 5, 2019
  6. 1/2 doc/fsck: clarify --connectivity-only behaviorJeff King, Mar 5, 2019
  7. 2/2 fsck: always compute USED flags for unreachable objectsJeff King, Mar 5, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.