[PATCH v2 31/35] builtin/difftool: use parse_oid_hex
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Feb 19, 2019, 00:05 UTC
- Message-ID
- <20190219000526.476553-32-sandals@crustytoothpaste.net>
- In-Reply-To
- <20190219000526.476553-1-sandals@crustytoothpaste.net>
Instead of using get_oid_hex and adding constants to the result, use parse_oid_hex to make this code independent of the hash size.
Additionally, correct a typo that would cause us to print one too few characters on error, since we will already have incremented the pointer to point to the beginning of the object ID before we get to printing the error message.
Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net> --- builtin/difftool.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/builtin/difftool.c b/builtin/difftool.c index a3ea60ea71..5fa83f481e 100644 --- a/builtin/difftool.c +++ b/builtin/difftool.c @@ -65,14 +65,12 @@ static int parse_index_info(char *p, int *mode1, int *mode2, *mode2 = (int)strtol(p + 1, &p, 8); if (*p != ' ') return error("expected ' ', got '%c'", *p); - if (get_oid_hex(++p, oid1)) - return error("expected object ID, got '%s'", p + 1); - p += GIT_SHA1_HEXSZ; + if (parse_oid_hex(++p, oid1, (const char **)&p)) + return error("expected object ID, got '%s'", p); if (*p != ' ') return error("expected ' ', got '%c'", *p); - if (get_oid_hex(++p, oid2)) - return error("expected object ID, got '%s'", p + 1); - p += GIT_SHA1_HEXSZ; + if (parse_oid_hex(++p, oid2, (const char **)&p)) + return error("expected object ID, got '%s'", p); if (*p != ' ') return error("expected ' ', got '%c'", *p); *status = *++p;