git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/10] dropping more unused function parameters

From
Jeff King <peff@peff.net>
Date
Feb 14, 2019, 05:47 UTC
Message-ID
<20190214054736.GA20091@sigill.intra.peff.net>

Here are ten more patches from my exploration of -Wunused-parameters. Most of these are quite old and not urgent, but things seem relatively quiet now, and they all merge cleanly with "pu".

In a sense they should all be trivial to review, as they only remove unused parameters. But the thing to consider is whether that parameter's lack of use is actually a bug, or if it's simply cruft (and I argue in each case in favor of cruft).

  [01/10]: diff: drop options parameter from diffcore_fix_diff_index()
  [02/10]: diff: drop unused color reset parameters
  [03/10]: diff: drop unused emit data parameter from sane_truncate_line()
  [04/10]: diff: drop complete_rewrite parameter from run_external_diff()
  [05/10]: merge-recursive: drop several unused parameters
  [06/10]: pack-objects: drop unused parameter from oe_map_new_pack()
  [07/10]: files-backend: drop refs parameter from split_symref_update()
  [08/10]: ref-filter: drop unused buf/sz pairs
  [09/10]: ref-filter: drop unused "obj" parameters
  [10/10]: ref-filter: drop unused "sz" parameters
 diff-lib.c           |  2 +-
 diff.c               | 31 ++++++++++++-------------------
 diff.h               |  2 +-
 merge-recursive.c    | 19 +++++++------------
 pack-objects.c       |  3 +--
 pack-objects.h       |  6 +++---
 ref-filter.c         | 36 ++++++++++++++++++------------------
 refs/files-backend.c |  5 ++---
 8 files changed, 45 insertions(+), 59 deletions(-)
-Peff
Next: Jeff King
Message 1 of 11 in “dropping more unused function parameters”
  1. 0/10 dropping more unused function parametersJeff King, Feb 14, 2019
  2. 01/10 diff: drop options parameter from diffcore_fix_diff_index()Jeff King, Feb 14, 2019
  3. 02/10 diff: drop unused color reset parametersJeff King, Feb 14, 2019
  4. 03/10 diff: drop unused emit data parameter from sane_truncate_line()Jeff King, Feb 14, 2019
  5. 04/10 diff: drop complete_rewrite parameter from run_external_diff()Jeff King, Feb 14, 2019
  6. 05/10 merge-recursive: drop several unused parametersJeff King, Feb 14, 2019
  7. 06/10 pack-objects: drop unused parameter from oe_map_new_pack()Jeff King, Feb 14, 2019
  8. 07/10 files-backend: drop refs parameter from split_symref_update()Jeff King, Feb 14, 2019
  9. 08/10 ref-filter: drop unused buf/sz pairsJeff King, Feb 14, 2019
  10. 09/10 ref-filter: drop unused "obj" parametersJeff King, Feb 14, 2019
  11. 10/10 ref-filter: drop unused "sz" parametersJeff King, Feb 14, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.