git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-gui: Handle Ctrl+BS & Ctrl+Del in the commit msg

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Feb 13, 2019, 03:35 UTC
Message-ID
<20190213033558.GJ684736@genre.crustytoothpaste.net>
In-Reply-To
<9EBA7C5F-4D59-45EE-B2E6-E7E76D7221EC@iodev.co.uk>
On Tue, Feb 12, 2019 at 12:24:40PM +0100, ismael@iodev.co.uk wrote:
> These bindings delete the word before and after the cursor
> respectively. It didn't seem necessary to describe the thing in detail
> because it has been commonplace for more than 30 years AFAICT.

I'm sure that these key bindings are familiar to you and probably to a lot of people, but I wasn't aware of them. I imagine there might be other people who aren't aware of them as well. The commit message is an opportunity for you to explain both what your patch does and argue why it's valuable.

It's also rather uncommon for commit messages in this project to lack a body; we typically prefer to say at least a few sentences about why we've chosen to make a change, even preferring to perhaps state some of the more obvious things just for clarity's sake to assist other people (and future us) in understanding what's going on.

This isn't me trying to be difficult, but rather to help you get your patch in a state that's most likely to be accepted. It's common here to do a couple of revisions of a patch, incorporating reviewers' comments and polishing along the way.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
Previous: brian m. carlson
Message 3 of 3 in “git-gui: Handle Ctrl+BS & Ctrl+Del in the commit msg”
  1. git-gui: Handle Ctrl+BS & Ctrl+Del in the commit msgIsmael Luceno, Feb 11, 2019
  2. brian m. carlsonFeb 12, 2019
  3. brian m. carlsonFeb 13, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.