Re: [PATCH 08/31] notes: make hash size independent
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Feb 12, 2019, 01:42 UTC
- Message-ID
- <20190212014215.GE684736@genre.crustytoothpaste.net>
- In-Reply-To
- <CAPig+cRQrkeD6rL8M9pL4kjPTwbPdjUYyH4Kes3jk9Wn0O-NtA@mail.gmail.com>
On Mon, Feb 11, 2019 at 08:37:49PM -0500, Eric Sunshine wrote:
Show 15 quoted lines
> On Mon, Feb 11, 2019 at 8:23 PM brian m. carlson > <sandals@crustytoothpaste.net> wrote: > > diff --git a/notes.c b/notes.c > > @@ -527,15 +529,15 @@ static unsigned char determine_fanout(struct int_node *tree, unsigned char n, > > -/* hex SHA1 + 19 * '/' + NUL */ > > -#define FANOUT_PATH_MAX GIT_SHA1_HEXSZ + FANOUT_PATH_SEPARATORS + 1 > > +/* hex oid + one slash between each pair + NUL */ > > +#define FANOUT_PATH_MAX GIT_MAX_HEXSZ + FANOUT_PATH_SEPARATORS_MAX + 1 > > I had trouble understanding to what pair you are referring. I _think_ > you mean "pair of hex digits". If so, perhaps: > > /* hex oid + '/' between each pair of hex digits + NUL */ > > (but not worth a re-roll).
Yes, I did. I fully expect to do at least one reroll here, so I'll update it when I do.
-- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204