Re: [PATCH] protocol-capabilities.txt: document symref
- From
Jeff King <peff@peff.net>
- Date
- Feb 12, 2019, 00:05 UTC
- Message-ID
- <20190212000530.GC13301@sigill.intra.peff.net>
- In-Reply-To
- <4ffb11ff776166944673ba3bdb96a9d20eb14df7.1549929088.git.steadmon@google.com>
On Mon, Feb 11, 2019 at 03:52:24PM -0800, Josh Steadmon wrote:
> In 7171d8c15f ("upload-pack: send symbolic ref information as
> capability"), we added a symref capability to the pack protocol, but it
> was never documented. Adapt the patch notes from that commit and add
> them to the capabilities documentation.Good catch, and your explanation (especially the SHOULD/MAY bits) looks good.
I think this is obsoleted by v2, which will send symref info along with each ref. I don't know if it's worth mentioning that here (the v2 docs discuss it, but I don't know if this capabilities document is clear about which ones apply only to v0).
-Peff