Re: [Breakage] Git v2.21.0-rc0 - t5403 (NonStop)
- From
Todd Zullinger <tmz@pobox.com>
- Date
- Feb 9, 2019, 06:48 UTC
- Message-ID
- <20190209064821.GG30548@zaya.teonanacatl.net>
- In-Reply-To
- <20190208203009.GC10587@szeder.dev>
[-cc: linux-kernel & git-packagers]
SZEDER Gábor wrote:
Show 11 quoted lines
> On Fri, Feb 08, 2019 at 03:11:29PM -0500, Todd Zullinger wrote: >> It made me wonder how I had missed it in my own testing. >> This one requires SHELL_PATH to be bash, while I only set >> TEST_SHELL_PATH to bash for the improved -x tracing in the >> fedora builds. > > Note that you don't need Bash to use '-x' tracing since a5bf824f3b (t: > prevent '-x' tracing from interfering with test helpers' stderr, > 2018-02-25) and the followup commits, except for 't1510-repo-setup.sh' > (and even t1510 just falls back to ignore '-x' instead of causing > failures).
Huh, cool. I somehow missed that nice improvement. Thanks for all your fine work on the test suite! It makes my life as a packager much better having a robust test suite running with each build.
-- Todd