git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] ci: make sure we build Git parallel

From
SZEDER Gábor <szeder.dev@gmail.com>
Date
Feb 7, 2019, 18:37 UTC
Message-ID
<20190207183736.9299-1-szeder.dev@gmail.com>

Commit 2c8921db2b (travis-ci: build with the right compiler, 2019-01-17) started to use MAKEFLAGS to specify which compiler to use to build Git. A bit later, and in a different topic branch commit eaa62291ff (ci: inherit --jobs via MAKEFLAGS in run-build-and-tests, 2019-01-27) started to use MAKEFLAGS as well. Unfortunately, there is a semantic conflict between these two commits: both of them set MAKEFLAGS, and since the line adding CC from 2c8921db2b comes later in 'ci/lib.sh', it overwrites the number of parallel jobs added in eaa62291ff.

Consequently, since both commits have been merged all our CI jobs have been building Git, building its documentation, and applying semantic patches sequentially, making all build jobs a bit slower. Running the test suite is unaffected, because the number of test jobs comes from GIT_PROVE_OPTS.

Append to MAKEFLAGS when setting the compiler to use, to ensure that the number of parallel jobs to use is preserved.

Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
---
 ci/lib.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ci/lib.sh b/ci/lib.sh
index 16f4ecbc67..cee51a4cc4 100755
--- a/ci/lib.sh
+++ b/ci/lib.sh
@@ -185,4 +185,4 @@ GIT_TEST_GETTEXT_POISON)
 	;;
 esac
 
-export MAKEFLAGS="CC=${CC:-cc}"
+export MAKEFLAGS="$MAKEFLAGS CC=${CC:-cc}"
-- 
2.20.1.940.g8404bb2d1a
Next: Junio C Hamano
Message 1 of 11 in “ci: make sure we build Git parallel”
  1. ci: make sure we build Git parallelSZEDER Gábor, Feb 7, 2019
  2. Junio C HamanoFeb 7, 2019
  3. Junio C HamanoFeb 7, 2019
  4. Junio C HamanoFeb 7, 2019
  5. Johannes SchindelinFeb 7, 2019
  6. Junio C HamanoFeb 7, 2019
  7. ci: clear and mark MAKEFLAGS exported just onceJunio C Hamano, Feb 7, 2019
  8. SZEDER GáborFeb 8, 2019
  9. Johannes SchindelinFeb 8, 2019
  10. Johannes SchindelinFeb 8, 2019
  11. Junio C HamanoFeb 8, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.