Re: [PATCH v3] doc-diff: don't `cd_to_toplevel`

From: Jeff King <peff@peff.net>
Date: Feb 6, 2019, 18:55 UTC
Message-ID: <20190206185520.GD10231@sigill.intra.peff.net>
In-Reply-To: <xmqqimxyrs4w.fsf@gitster-ct.c.googlers.com>

On Tue, Feb 05, 2019 at 10:45:35AM -0800, Junio C Hamano wrote:

Show 5 quoted lines

>  - Perhaps find the fork point, run tests to find known breakages
>    and exclude them?  This would simply be not practical, as it
>    doubles the number of tests run, for individual topic branches
>    because there are an order of magnitude more of them than the
>    primary integration branches.

I think this can be limited to the tests that failed, which makes things much faster. I.e., we run the tests at the tip of topic X and see that t1234 fails. We then go back to the fork point and we just need to run t1234 again. If it succeeds, then we blame X for the failure. If it fails, then we consider it a false positive.

You do pay the price to do a full build at the fork point, but in my experience that is much quicker than the tests.

-Peff