Re: unclear docs

From: Jeff King <peff@peff.net>
Date: Jan 28, 2019, 18:32 UTC
Message-ID: <20190128183253.GB13165@sigill.intra.peff.net>
In-Reply-To: <xmqqzhrkab3s.fsf@gitster-ct.c.googlers.com>

On Mon, Jan 28, 2019 at 10:30:31AM -0800, Junio C Hamano wrote:

Show 19 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > I think it means:
> >
> >   - if core.autocrlf is false (the default), then the text attribute and
> >     core.eol are used
> >
> >   - if core.autocrlf is true, then that overrides the whole
> >     attribute/eol system
> 
> I think that matches my understanding.
> 
> > Subject: [PATCH] doc/gitattributes: clarify "autocrlf overrides eol"
> >
> > We only override core.eol with core.autocrlf when the latter is set to
> > "true" (otherwise, core.eol would never do anything!). Let's make this
> 
> I fail to understand what "otherwise..." wants to say.  When
> core.autocrlf is not "true", core.eol would not do anything?

I meant that if core.autocrlf overrides core.eol also when it is not set to true, then there would be no way to use core.eol, because the former must be either true or false.

I suppose one could argue that it can be "unset", though.

> But I can understand what the patch text says and it matches my
> understanding of the overriding behaviour, so let's queue it.

Thanks. I just posted a follow-up patch elsewhere in the thread. I think it makes sense to do both.

-Peff