git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v1] git-instaweb: Add Python builtin http.server support

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Jan 25, 2019, 23:58 UTC
Message-ID
<20190125235811.GW423984@genre.crustytoothpaste.net>
In-Reply-To
<5bc3256d49834c96db2a51c12190f2cb7cf7ac42.camel@gmail.com>
On Fri, Jan 25, 2019 at 05:22:45PM +0200, Arti Zirk wrote:
Show 11 quoted lines
> This is the built in http server that Python comes with (like Ruby
> users have builtin webrick server). While it is possible to install
> something else, I don't think many casual git-instaweb users would do
> it. 
> 
> I haven't looked in depth into it but I'm pretty sure that by simply
> changing the imports I could make this code also work in python2.
> 
> Upstream python2 support ends in ~11 months and would Red Hat/CentOS 7
> users using new git releases really care about "git instaweb -d python"
> not working on installations without Python 3?

I'm sensitive to the fact that upstream is dropping support for Python 2, and I have no objections to limiting this to Python 3. However, whether we like it or not, Red Hat/CentOS 7 is going to be around for four years after that.

> In the end I would like to keep the name just "python" to signal that
> it only needs standard Python installation and nothing else.

Could you update the documentation to put "Python 3" in parentheses or otherwise make it clear in the documentation? My goal is to avoid confusing users who are on systems that still have Python 2.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
Previous: Arti ZirkNext: Junio C Hamano
Message 6 of 11 in “git-instaweb: Add Python builtin http.server support”
  1. git-instaweb: Add Python builtin http.server supportArti Zirk, Jan 24, 2019
  2. Junio C HamanoJan 24, 2019
  3. brian m. carlsonJan 25, 2019
  4. Junio C HamanoJan 25, 2019
  5. Arti ZirkJan 25, 2019
  6. brian m. carlsonJan 25, 2019
  7. Junio C HamanoJan 28, 2019
  8. git-instaweb: Add Python builtin http.server supportArti Zirk, Jan 28, 2019
  9. brian m. carlsonJan 28, 2019
  10. Arti ZirkJan 28, 2019
  11. Junio C HamanoJan 28, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.