Re: [PATCH v4 00/10] Create 'expire' and 'repack' verbs for git-multi-pack-index
- From
- Jonathan Tan <jonathantanmy@google.com>
- Date
- Jan 24, 2019, 22:14 UTC
- Message-ID
- <20190124221457.11062-1-jonathantanmy@google.com>
- In-Reply-To
- <pull.92.v4.git.gitgitgadget@gmail.com>
Show 18 quoted lines
> Updates in V4: > > * More 'verb' and 'command' instances replaced with 'subcommand'. I grepped > the patch to check these should be fixed everywhere. > > > * Update the tests to check .keep files (in last patch). > > > * Modify the tests to show the terminating condition of --batch-size when > there are three packs that fit under the size, but the first two are > large enough to stop adding packs. This required rearranging the packs > slightly to get different sizes than we had before. Also, I added 'touch > -t' to set the modified times so we can fix the order in which the packs > are selected. > > > * Added a comment about the purpose of pack_perm.
Thanks, the interdiff and patch 10 look good to me (I already reviewed V3). I also verified that in the last test, if there is no .keep file, the test fails as expected.