git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 01/13] fetch: fix extensions.partialclone name in error message

From
Christian Couder <christian.couder@gmail.com>
Date
Jan 22, 2019, 14:42 UTC
Message-ID
<20190122144212.15119-2-chriscool@tuxfamily.org>
In-Reply-To
<20190122144212.15119-1-chriscool@tuxfamily.org>

There is "extensions.partialclone" and "core.partialCloneFilter", but not "core.partialclone". Only "extensions.partialclone" is meant to contain a remote name.

While at it, let's wrap the relevant code lines to keep them at a reasonable length.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 builtin/fetch.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/builtin/fetch.c b/builtin/fetch.c
index e0140327aa..c0ade48f5d 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -1478,7 +1478,8 @@ static inline void fetch_one_setup_partial(struct remote *remote)
 	 */
 	if (strcmp(remote->name, repository_format_partial_clone)) {
 		if (filter_options.choice)
-			die(_("--filter can only be used with the remote configured in core.partialClone"));
+			die(_("--filter can only be used with the remote "
+			      "configured in extensions.partialclone"));
 		return;
 	}
 
@@ -1646,7 +1647,8 @@ int cmd_fetch(int argc, const char **argv, const char *prefix)
 		result = fetch_one(remote, argc, argv, prune_tags_ok);
 	} else {
 		if (filter_options.choice)
-			die(_("--filter can only be used with the remote configured in core.partialClone"));
+			die(_("--filter can only be used with the remote "
+			      "configured in extensions.partialclone"));
 		/* TODO should this also die if we have a previous partial-clone? */
 		result = fetch_multiple(&list);
 	}
-- 
2.20.1.322.gd6b9ae60d4
Previous: Christian CouderNext: Christian Couder
Message 2 of 14 in “Many promisor remotes”
  1. 00/13 Many promisor remotesChristian Couder, Jan 22, 2019
  2. 01/13 fetch: fix extensions.partialclone name in error messageChristian Couder, Jan 22, 2019
  3. 02/13 partial-clone: add missing 'is' in docChristian Couder, Jan 22, 2019
  4. 03/13 fetch-object: make functions return an error codeChristian Couder, Jan 22, 2019
  5. 06/13 promisor-remote: add promisor_remote_reinit()Christian Couder, Jan 22, 2019
  6. 07/13 promisor-remote: use repository_format_partial_cloneChristian Couder, Jan 22, 2019
  7. 05/13 promisor-remote: implement promisors_get_direct()Christian Couder, Jan 22, 2019
  8. 04/13 Add initial support for many promisor remotesChristian Couder, Jan 22, 2019
  9. 11/13 t0410: test fetching from many promisor remotesChristian Couder, Jan 22, 2019
  10. 13/13 remote: add promisor and partial clone config to the docChristian Couder, Jan 22, 2019
  11. 09/13 promisor-remote: parse remote.*.partialclonefilterChristian Couder, Jan 22, 2019
  12. 10/13 builtin/fetch: remove unique promisor remote limitationChristian Couder, Jan 22, 2019
  13. 08/13 Use promisor_remote_get_direct() and has_promisor_remote()Christian Couder, Jan 22, 2019
  14. 12/13 partial-clone: add multiple remotes in the docChristian Couder, Jan 22, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.