git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] upload-pack: teach deepen-relative in protocol v2

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Jan 10, 2019, 22:11 UTC
Message-ID
<20190110221132.52443-1-jonathantanmy@google.com>
In-Reply-To
<20190110212857.58772-1-jonathantanmy@google.com>
Show 10 quoted lines
> > This, when applied on top of ecbdaf08991, seems to break t5702.30,
> > at least for me.
> > 
> > Tip of 'pu' in today's push-out will be broken as it has this patch
> > merged.
> > 
> > Can somebody take a look?
> 
> I can reproduce this. I'll investigate this further. In the meantime,
> feel free to remove this from pu.

The test failure is caused by a bug I fixed in [1]. I've verified that if I apply [1] first, then this, all tests pass. If you do include this patch in some branch, it should be dependent on [1], but I understand if you'd like reviewers to look at both this and [1] first.

I thought I tested this without something that fixes the issue fixed by [1] and it passed, but apparently that's not true.

[1] https://public-inbox.org/git/20190110193645.34080-1-jonathantanmy@google.com/
Previous: Jonathan TanNext: Junio C Hamano
Message 6 of 7 in “upload-pack: teach deepen-relative in protocol v2”
  1. upload-pack: teach deepen-relative in protocol v2Jonathan Tan, Dec 18, 2018
  2. Josh SteadmonJan 9, 2019
  3. Junio C HamanoJan 10, 2019
  4. Junio C HamanoJan 10, 2019
  5. Jonathan TanJan 10, 2019
  6. Jonathan TanJan 10, 2019
  7. Junio C HamanoJan 10, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.