Re: [PATCH v3 0/2] support for filtering trees and blobs based on depth

From: Jonathan Tan <jonathantanmy@google.com>
Date: Jan 9, 2019, 18:06 UTC
Message-ID: <20190109180633.10273-1-jonathantanmy@google.com>
In-Reply-To: <20190109025914.247473-1-matvore@google.com>

Show 9 quoted lines

> This applies suggestions from Jonathan Tan and Junio. These are mostly
> stylistic and readability changes, although there is also an added test case
> in t/t6112-rev-list-filters-objects.sh which checks for the scenario when
> filtering which would exclude a blob, but the blob is given on the command
> line.
> 
> This has been rebased onto master, while the prior version was based on next.
> 
> Thank you,

Thanks, these 2 patches are Reviewed-by: me.

Your approach in the 2nd patch makes more sense, and I checked that both oidset_insert() and oidset_remove() return 1 when the element in question was in the set (prior to invocation of the function), so that works.