Re: [PATCH 2/1] Revert "t/lib-git-daemon: record daemon log"

From: Jeff King <peff@peff.net>
Date: Jan 7, 2019, 08:20 UTC
Message-ID: <20190107082041.GA21362@sigill.intra.peff.net>
In-Reply-To: <20190106175310.GC25639@hank.intra.tgummerer.com>

On Sun, Jan 06, 2019 at 05:53:10PM +0000, Thomas Gummerer wrote:

Show 16 quoted lines

> This reverts commit 314a73d658 (t/lib-git-daemon: record daemon log,
> 2018-01-25), which let tests use the output of git-daemon.
> 
> The previous commit removed the last user of deamon.log in the tests,
> there's no good way to make checking for output in the log
> race-proof.  Revert this commit as well, to make sure others are not
> tempted to use daemon.log in tests in the future, which would lead to
> racy tests.
> 
> The original commit had one change that still makes sense, namely
> switching read/echo for "read -r" and "printf", which relays the data
> more faithfully.  Don't revert that piece here, as it is still a
> useful change.
> 
> Suggested-by: Jeff King <peff@peff.net>
> Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>

Yep, this looks good to me. Thanks for being extra careful with the read/printf bits!

Looks like Junio already queued a99653a9b6 (Revert "t/lib-git-daemon: record daemon log", 2018-12-28) on the tip of tg/t5570-drop-racy-test, but that's a pure revert. I think we can replace it with this.

-Peff