[PATCH] banned.h: mark strncat() as banned
- From
- Eric Wong <e@80x24.org>
- Date
- Jan 2, 2019, 09:38 UTC
- Message-ID
- <20190102093846.6664-1-e@80x24.org>
strncat() has the same quadratic behavior as strcat() and is difficult-to-read and bug-prone. While it hasn't yet been a problem in git iself, strncat() found it's way into 'master' of cgit and caused segfaults on my system.
Signed-off-by: Eric Wong <e@80x24.org> --- banned.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/banned.h b/banned.h index 28f5937035..447af24807 100644 --- a/banned.h +++ b/banned.h @@ -16,6 +16,8 @@ #define strcat(x,y) BANNED(strcat) #undef strncpy #define strncpy(x,y,n) BANNED(strncpy) +#undef strncat +#define strncat(x,y,n) BANNED(strncat) #undef sprintf #undef vsprintf
-- EW