git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] setup: do not use invalid `repository_format`

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Dec 19, 2018, 00:18 UTC
Message-ID
<20181219001801.GA520988@genre.crustytoothpaste.net>
In-Reply-To
<20181218072528.3870492-3-martin.agren@gmail.com>
On Tue, Dec 18, 2018 at 08:25:27AM +0100, Martin Ågren wrote:
>  I fully admit to not understanding all of this setup code, neither in
>  its current incarnation, nor in terms of an ideal end game. This check
>  seems like a good thing to do though.
It's definitely complex.
Show 12 quoted lines
> diff --git a/setup.c b/setup.c
> index 27747af7a3..52c3c9d31f 100644
> --- a/setup.c
> +++ b/setup.c
> @@ -1138,7 +1138,7 @@ const char *setup_git_directory_gently(int *nongit_ok)
>  				gitdir = DEFAULT_GIT_DIR_ENVIRONMENT;
>  			setup_git_env(gitdir);
>  		}
> -		if (startup_info->have_repository)
> +		if (startup_info->have_repository && repo_fmt.version > -1)
>  			repo_set_hash_algo(the_repository, repo_fmt.hash_algo);
>  	}

I think this change is fine, because we initialize the value in the_repository elsewhere, and if there's no repository, this should never have a value other than the default anyway.

I looked at the other patches in the series and thought they looked sane as well.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
Previous: Martin ÅgrenNext: Martin Ågren
Message 10 of 40 in “setup: add `clear_repository_format()`”
  1. 0/3 setup: add `clear_repository_format()`Martin Ågren, Dec 18, 2018
  2. 1/3 setup: drop return value from `read_repository_format()`Martin Ågren, Dec 18, 2018
  3. Jeff KingDec 19, 2018
  4. Martin ÅgrenDec 19, 2018
  5. brian m. carlsonDec 20, 2018
  6. Jeff KingDec 20, 2018
  7. brian m. carlsonDec 20, 2018
  8. Jeff KingDec 20, 2018
  9. 2/3 setup: do not use invalid `repository_format`Martin Ågren, Dec 18, 2018
  10. brian m. carlsonDec 19, 2018
  11. Martin ÅgrenDec 19, 2018
  12. Jeff KingDec 19, 2018
  13. Martin ÅgrenDec 19, 2018
  14. Jeff KingDec 19, 2018
  15. brian m. carlsonDec 20, 2018
  16. 3/3 setup: add `clear_repository_format()`Martin Ågren, Dec 18, 2018
  17. Jeff KingDec 19, 2018
  18. Martin ÅgrenDec 19, 2018
  19. 0/3 setup: add `clear_repository_format()`Martin Ågren, Jan 14, 2019
  20. 1/3 setup: free old value before setting `work_tree`Martin Ågren, Jan 14, 2019
  21. 2/3 setup: do not use invalid `repository_format`Martin Ågren, Jan 14, 2019
  22. Jeff KingJan 15, 2019
  23. Martin ÅgrenJan 17, 2019
  24. Jeff KingJan 22, 2019
  25. Martin ÅgrenJan 22, 2019
  26. 0/2 setup: fix memory leaks with `struct repository_format`Martin Ågren, Jan 22, 2019
  27. 1/2 setup: free old value before setting `work_tree`Martin Ågren, Jan 22, 2019
  28. 2/2 setup: fix memory leaks with `struct repository_format`Martin Ågren, Jan 22, 2019
  29. Jeff KingJan 23, 2019
  30. brian m. carlsonJan 24, 2019
  31. Martin ÅgrenJan 25, 2019
  32. Martin ÅgrenJan 25, 2019
  33. Jeff KingJan 25, 2019
  34. Martin ÅgrenFeb 25, 2019
  35. Jeff KingFeb 26, 2019
  36. 0/2 setup: fix memory leaks with `struct repository_format`Martin Ågren, Feb 28, 2019
  37. 1/2 setup: free old value before setting `work_tree`Martin Ågren, Feb 28, 2019
  38. 2/2 setup: fix memory leaks with `struct repository_format`Martin Ågren, Feb 28, 2019
  39. Jeff KingMar 6, 2019
  40. 3/3 setup: add `clear_repository_format()`Martin Ågren, Jan 14, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.