Re: [PATCH v2 8/8] tests: mark tests broken under GIT_TEST_PROTOCOL_VERSION=2
- From
Jeff King <peff@peff.net>
- Date
- Dec 17, 2018, 19:59 UTC
- Message-ID
- <20181217195919.GB10673@sigill.intra.peff.net>
- In-Reply-To
- <87mup81i3x.fsf@evledraar.gmail.com>
On Fri, Dec 14, 2018 at 12:08:02PM +0100, Ævar Arnfjörð Bjarmason wrote:
Show 8 quoted lines
> Also, parts of the v2 code, e.g. this in 685fbd3291 ("fetch-pack:
> perform a fetch using v2", 2018-03-15):
>
> /* v2 supports these by default */
> allow_unadvertised_object_request |= ALLOW_REACHABLE_SHA1;
>
> Seem to have intended to turn on allowReachableSHA1InWant, not
> allowAnySHA1InWant, but apparently that's what we're doing?That I don't know. Maybe Brandon can answer what the intent was.
I agree that turning on the reachability check would make it behavior more or less the same as v0 (at some additional cost to walk the refs again, but v0 smart-http already had to do that).
-Peff