Re: [PATCH] log: add %S option (like --source) to log --format

From: Jeff King <peff@peff.net>
Date: Dec 17, 2018, 15:59 UTC
Message-ID: <20181217155915.GA914@sigill.intra.peff.net>
In-Reply-To: <CANdyxMwxPqTMfLsoK-2JT3Wf3hXZnQNCPRS04aSHzsMbYJZo-Q@mail.gmail.com>

On Sun, Dec 16, 2018 at 10:25:14PM -0800, Issac Trotts wrote:

Show 6 quoted lines

> Make it possible to write for example
> 
>         git log --format="%H,%S"
> 
> where the %S at the end is a new placeholder that prints out the ref
> (tag/branch) for each commit.

Seems like a reasonable thing to want.

One curious thing about "--source" is that it requires cooperation from the actual traversal. So if you did:

  git rev-list | git diff-tree --format="%H %S"

we don't have the %S information in the latter command. I think that's probably acceptable as long as it does something sane when we don't have that information (e.g., replace it with an empty string). It might also be worth calling out in the documentation.

-Peff