git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] RF+ENH(TST): compare the entire list of submodule status --recursive to stay intact

From
Yaroslav O Halchenko <debian@onerussian.com>
Date
Dec 13, 2018, 22:43 UTC
Message-ID
<20181213224356.GI4633@hopa.kiewit.dartmouth.edu>
In-Reply-To
<CAGZ79kZb28bCvM7cOYHC4cpJWpA-3_gcbxS_g-rG0yy=9jXquw@mail.gmail.com>
On Thu, 13 Dec 2018, Stefan Beller wrote:
> > and kaboom -- we have a new test.  If we decide to test more -- just tune up
> > test_expect_unchanged_submodule_status and done -- all the tests remain
> > sufficiently prescribed.
> > What do you think?
> That is pretty cool. Maybe my gut reaction on the previous patch
> also had to do with the numbers, i.e. having 2 extra function for
> only having 2 tests more legible. A framework is definitely better
> once we have more tests.
cool, thanks for the feedback - I will then try to make it happen

quick one (so when I get to it I know): should I replicate all those tests you have for other update strategies? (treating of config specifications etc) There is no easy way to parametrize them somehow? ;) In Python world I might have mocked the actual underlying call to update, to see what option it would be getting and assure that it is the one I specified via config, and then sweepped through all of them to make sure nothing interim changes it. Just wondering if may be something like that exists in git's tests support.

BTW - sorry if RTFM and unrelated, is there  a way to  
    update --merge

but allowing only fast-forwards? My use case is collection of this submodules: http://datasets.datalad.org/?dir=/openneuro which all should come from github and I should not have any changes of my own. Sure thing if all is clean etc, merge should result in fast-forward. I just do not want to miss a case where there was some (temporary?) "dirt" which I forgot to reset and it would then get merged etc.

-- 
Yaroslav O. Halchenko
Center for Open Neuroscience     http://centerforopenneuroscience.org
Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
Phone: +1 (603) 646-9834                       Fax: +1 (603) 646-1419
WWW:   http://www.linkedin.com/in/yarik
Previous: Stefan BellerNext: Stefan Beller
Message 16 of 18 in “[wishlist] git submodule update --reset-hard”
  1. Yaroslav HalchenkoDec 6, 2018
  2. Stefan BellerDec 6, 2018
  3. Yaroslav HalchenkoDec 6, 2018
  4. Stefan BellerDec 6, 2018
  5. Yaroslav HalchenkoDec 7, 2018
  6. Stefan BellerDec 7, 2018
  7. Yaroslav HalchenkoDec 8, 2018
  8. Yaroslav HalchenkoDec 8, 2018
  9. Stefan BellerDec 10, 2018
  10. Yaroslav HalchenkoDec 10, 2018
  11. 1/2 submodule: Add --reset-hard option for git submodule updateYaroslav Halchenko, Dec 11, 2018
  12. 2/2 RF+ENH(TST): compare the entire list of submodule status --recursive to stay intactYaroslav Halchenko, Dec 11, 2018
  13. Stefan BellerDec 12, 2018
  14. Yaroslav O HalchenkoDec 13, 2018
  15. Stefan BellerDec 13, 2018
  16. Yaroslav O HalchenkoDec 13, 2018
  17. Stefan BellerDec 13, 2018
  18. Yaroslav O HalchenkoDec 14, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.