Re: [wishlist] submodule.update config

From: Yaroslav Halchenko <yoh@onerussian.com>
Date: Dec 10, 2018, 22:49 UTC
Message-ID: <20181210224901.GL4633@hopa.kiewit.dartmouth.edu>
In-Reply-To: <CAGZ79kY+F776YfNBrx3wk3ffv4sqqabM5iJxbQDiPE6xoio69w@mail.gmail.com>

On Mon, 10 Dec 2018, Stefan Beller wrote:

Show 6 quoted lines

> > I wondered, if you think it would be sensible to also add of
> > submodule.update which would be considered before submodule.SUBMODULE.update
> > variable possibly defined per submodule.  That would be more inline with desire
> > to use any of the --merge, --rebase (and hopefully soon --reset-hard)
> > strategies specified as an option for submodule update, where no per-submodule
> > handling  is happening.

> > Thanks in advance for the consideration!

> So you are proposing a variable like submodule.update
> without the .<name>. that would apply to any submodule?

yes

> The precedence in descending order of these
> configs that modify the behavior of "git submodule update"
> would be:

> * the command line flag (--merge/--rebase/--checkout)
> * submodule specific instructions (submodule.<name>.update)
> * generic submodule config (the new submodule.update)
> * default as --checkout

sound great

Show 6 quoted lines

> I first hesitated in thinking this would be a good addition,
> as there is no plumbing command for submodules,
> to easily modify submodules irrespective of the user
> config. But that is out already with the submodule
> specific update configs.
> So I think it may be a good addition.

Glad to hear that. Not sure though I would know where to stick my nose to figure out what to change. ;-)

> I wonder if we'd be better off to re-invent the UX instead
> of hiding your intentions in a config setting for a command
> that is already long to type. What about

>   git submodule merge
>   git submodule rebase
>   git submodule checkout
>   git submodule reset (--hard)

> as aliases for
>   git submodule update (...)

Well, not sure... In the long run, if UX is to be tuned up, I wonder if it would be more worthwhile to look toward making all those git commands (git merge, git checkout, git rebase, ..., git revert, git cherry-pick) support --recurse-submodules with a consistent with the non-recursive operation by default behavior (e.g. not introducing detached HEADs or controlling that via a set of additional options where needed). I feel that "git-submodule" ideally should not get its interface extended to complement everything "git" commands can do, although that might need to be extended to provide necessary plumbing. As for the UX, it should provide only the set of additional commands, which could not be present in the main API (e.g. pure "git submodule" itself to list submodules, and "submodule foreach", "init", "deinit").

-- 
Yaroslav O. Halchenko
Center for Open Neuroscience     http://centerforopenneuroscience.org
Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755
Phone: +1 (603) 646-9834                       Fax: +1 (603) 646-1419
WWW:   http://www.linkedin.com/in/yarik