Re: [PATCH] rebase -i: introduce the 'test' command

From: Jeff King <peff@peff.net>
Date: Dec 3, 2018, 21:34 UTC
Message-ID: <20181203213419.GE8700@sigill.intra.peff.net>
In-Reply-To: <20181203175322.GA3892@duynguyen.home>

On Mon, Dec 03, 2018 at 06:53:22PM +0100, Duy Nguyen wrote:

Show 12 quoted lines

> On Sat, Dec 01, 2018 at 03:02:09PM -0500, Jeff King wrote:
> > I sometimes add "x false" to the top of the todo list to stop and create
> > new commits before the first one.
> 
> And here I've been doing the same by "edit" the first commit, add a
> new commit then reorder them in the second interactive rebase :P
> 
> This made me look at git-rebase.txt to really learn about interactive
> rebase. I think the interactive rebase section could use some
> improvements. Its style looks.. umm.. more story telling than a
> reference. Perhaps something like this to at least highlight the
> commands.

Yeah, I think the typographic change is an improvement that doesn't really have a downside.

As Dscho mentioned, sometimes the story style is what you want, so I don't think we'd want to simply rearrange it. It may be useful to present the material twice, though: once as a table/list for reference, and then once as a story working through an example.

-Peff