git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] tests: avoid syntax triggering old dash bug

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Nov 27, 2018, 16:42 UTC
Message-ID
<20181127164253.9832-1-avarab@gmail.com>

Avoid a bug in dash that's been fixed ever since its ec2c84d ("[PARSER] Fix clobbering of checkkwd", 2011-03-15)[1] first released with dash v0.5.7 in July 2011.

This fixes 1/2 tests failing on Debian Lenny & Squeeze. The other failure is due to 1b42f45255 ("git-svn: apply "svn.pathnameencoding" before URL encoding", 2016-02-09).

This particular test has been failing since 5f9674243d ("config: add --expiry-date", 2017-11-18).

1. https://git.kernel.org/pub/scm/utils/dash/dash.git/
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 t/t1300-config.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/t1300-config.sh b/t/t1300-config.sh
index 9652b241c7..7690b518b8 100755
--- a/t/t1300-config.sh
+++ b/t/t1300-config.sh
@@ -892,8 +892,9 @@ test_expect_success 'get --expiry-date' '
 	1510348087
 	0
 	EOF
+	date_valid1=$(git config --expiry-date date.valid1) &&
 	{
-		echo "$rel_out $(git config --expiry-date date.valid1)"
+		echo "$rel_out $date_valid1"
 		git config --expiry-date date.valid2 &&
 		git config --expiry-date date.valid3 &&
 		git config --expiry-date date.valid4 &&
-- 
2.20.0.rc1.379.g1dd7ef354c
Next: Eric Sunshine
Message 1 of 10 in “tests: avoid syntax triggering old dash bug”
  1. tests: avoid syntax triggering old dash bugÆvar Arnfjörð Bjarmason, Nov 27, 2018
  2. Eric SunshineNov 27, 2018
  3. Ævar Arnfjörð BjarmasonNov 27, 2018
  4. Junio C HamanoNov 28, 2018
  5. tests: avoid syntax triggering old dash bugÆvar Arnfjörð Bjarmason, Feb 13, 2019
  6. Junio C HamanoFeb 13, 2019
  7. SZEDER GáborFeb 13, 2019
  8. Ævar Arnfjörð BjarmasonFeb 14, 2019
  9. brian m. carlsonNov 28, 2018
  10. Torsten BögershausenNov 28, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.