git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] test-lib-functions: make 'test_cmp_rev' more informative on failure

From
Jeff King <peff@peff.net>
Date
Nov 20, 2018, 11:37 UTC
Message-ID
<20181120113728.GB29319@sigill.intra.peff.net>
In-Reply-To
<20181120112538.GX30222@szeder.dev>
On Tue, Nov 20, 2018 at 12:25:38PM +0100, SZEDER Gábor wrote:
Show 5 quoted lines
> > but we do not
> > usually bother to do so for our helper functions (like test_cmp).
> 
> test_i18ngrep() does since your 03aa3783f2 (t: send verbose
> test-helper output to fd 4, 2018-02-22).

Oh, indeed. Usually I find myself forgetting about patches I worked on from 5 years ago. Forgetting about one from 9 months ago is a new low. :)

Show 8 quoted lines
> > I don't think it would ever hurt,
> > though. Should we be doing that for all the others, too?
> 
> I think we should, and you agreed:
> 
> https://public-inbox.org/git/20180303065648.GA17312@sigill.intra.peff.net/
> 
> but then went travelling, and then the whole thing got forgotten.
Stupid vacation. :)

OK, yes, I reaffirm my agreement that this is the right direction, then. Sorry for my lack of memory.

-Peff
Previous: SZEDER Gábor
Message 5 of 5 in “test-lib-functions: make 'test_cmp_rev' more informative on failure”
  1. test-lib-functions: make 'test_cmp_rev' more informative on failureSZEDER Gábor, Nov 19, 2018
  2. SZEDER GáborNov 19, 2018
  3. Jeff KingNov 19, 2018
  4. SZEDER GáborNov 20, 2018
  5. Jeff KingNov 20, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.