Re: [PATCH] tests: send "bug in the test script" errors to the script's stderr

From: Jeff King <peff@peff.net>
Date: Nov 20, 2018, 10:45 UTC
Message-ID: <20181120104528.GA26263@sigill.intra.peff.net>
In-Reply-To: <20181119233404.GW30222@szeder.dev>

On Tue, Nov 20, 2018 at 12:34:04AM +0100, SZEDER Gábor wrote:

Show 9 quoted lines

> > I do notice that many of the existing "FATAL:" errors use descriptor 5,
> > which goes to stdout. I'm not sure if those should actually be going to
> > stderr (or if there's some TAP significance to those lines).
> 
> I chose to send these messages to standard error, because they are,
> well, errors.  TAP only cares about stdout, but by aborting the test
> script in BUG(), error() or die() we are already violating TAP anyway,
> so I don't think it matters whether we send "bug in test script" or
> "FATAL" errors to stdout or stderr.

Yeah, I agree it probably doesn't matter. I was mostly suggesting to make the existing ">&5" into ">&7" for consistency. But I don't think that needs to block your patch.

> BTW, TAP understands "Bail out!" as bail out from the _entire_ test
> suite, but that's not what we want here, I'd think.
> 
> https://testanything.org/tap-specification.html#bail-out

Yes, I added the only existing "Bail out!" to test-lib.sh. :)

I agree that's not what we want here. I actually think the current behavior (to exit non-zero) does what we want. A TAP harness will realize that's an error, but not block other scripts.

-Peff