[PATCH 2/3] remote-curl: tighten "version 2" check for smart-http
- From
Jeff King <peff@peff.net>
- Date
- Nov 16, 2018, 08:48 UTC
- Message-ID
- <20181116084838.GB31603@sigill.intra.peff.net>
- In-Reply-To
- <20181116084427.GA31493@sigill.intra.peff.net>
In a v2 smart-http conversation, the server should reply to our initial request with a pkt-line saying "version 2" (this is the start of the "capabilities advertisement"). We check for the string using starts_with(), but that's overly permissive (it would match "version 20", for example).
Let's tighten this check to use strcmp(). Note that we don't need to worry about a trailing newline here, because the ptk-line code will have chomped it for us already.
Signed-off-by: Jeff King <peff@peff.net> --- remote-curl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/remote-curl.c b/remote-curl.c index dd9bc41aa1..3c9c4a07c3 100644 --- a/remote-curl.c +++ b/remote-curl.c @@ -375,7 +375,7 @@ static void check_smart_http(struct discovery *d, const char *service, d->len = src_len; d->proto_git = 1; - } else if (starts_with(line, "version 2")) { + } else if (!strcmp(line, "version 2")) { /* * v2 smart http; do not consume version packet, which will * be handled elsewhere.
-- 2.19.1.1636.gc7a073d580