Re: [PATCH 2/5] tests: respect GIT_TEST_INSTALLED when initializing repositories

From: Jeff King <peff@peff.net>
Date: Nov 15, 2018, 12:41 UTC
Message-ID: <20181115124119.GA25562@sigill.intra.peff.net>
In-Reply-To: <nycvar.QRO.7.76.6.1811151329150.41@tvgsbejvaqbjf.bet>

On Thu, Nov 15, 2018 at 01:29:58PM +0100, Johannes Schindelin wrote:

Show 17 quoted lines

> > Do we actually care where the templates are? I thought the point was to
> > override for the built Git to use the built templates instead of the
> > installed one. For an installed Git, shouldn't we not be overriding the
> > templates at all? I.e.:
> > 
> >   if test -n "$GIT_TEST_INSTALLED"
> >   then
> > 	"$GIT_TEST_INSTALLED/git" init
> >   else
> > 	"$GIT_ExEC_PATH/git" init --template="$GIT_BUILD_DIR/templates/blt"
> >   fi >&3 2>&4
> > 
> > (That's all leaving aside the question of whether we ought to be using a
> > clean template dir instead of this).
> 
> I fear that that might buy us a ton of trouble. Just like we override the
> system config, we should override the templates.

Yes, it might. I guess it just seems plausible to me that somebody would expect GIT_TEST_INSTALLED to be as close to the installed experience as possible. I dunno. I do not use it myself.

At any rate, my point was that for GIT_TEST_INSTALLED, either:

  1. We can use a known-clean set of templates (either our local
     templates/blt, or an even-cleaner empty set).

or

  2. We do not need to specify any template, and it will just use
     whatever it came installed with.

And in either case, we do not have to worry about asking it "where are your templates?".

-Peff