Re: [PATCH v2 1/1] Upcast size_t variables to uintmax_t when printing

From: Torsten Bögershausen <tboegi@web.de>
Date: Nov 11, 2018, 10:16 UTC
Message-ID: <20181111101650.GA4471@tor.lan>
In-Reply-To: <20181111072835.GL30850@sigill.intra.peff.net>

On Sun, Nov 11, 2018 at 02:28:35AM -0500, Jeff King wrote:

Show 19 quoted lines

> On Sun, Nov 11, 2018 at 08:05:04AM +0100, tboegi@web.de wrote:
> 
> > From: Torsten Bögershausen <tboegi@web.de>
> > 
> > When printing variables which contain a size, today "unsigned long"
> > is used at many places.
> > In order to be able to change the type from "unsigned long" into size_t
> > some day in the future, we need to have a way to print 64 bit variables
> > on a system that has "unsigned long" defined to be 32 bit, like Win64.
> > 
> > Upcast all those variables into uintmax_t before they are printed.
> > This is to prepare for a bigger change, when "unsigned long"
> > will be converted into size_t for variables which may be > 4Gib.
> 
> I like the overall direction. I feel a little funny doing this step now,
> and not as part of a series to convert individual variables. But I
> cannot offhand think of any reason that it would behave badly even if
> the other part does not materialize
>

Hej all,
There may be some background information missing:
- I did a 2-patch series based on this commit in pu:
    commit 37c59c3e8fac8bae7ccc5baa148b0e9bae0c8d65
    Author: Junio C Hamano <gitster@pobox.com>
    Date:   Sat Oct 27 16:42:25 2018 +0900

        treewide: apply cocci patch

(that patch was never send out, see below) .... The week later, I tried to apply it on pu, but that was nearly hopeless, as too much things had changed on pu. I had the chance to compile & test it, but decided to take "part2" before "part1", so to say: Fix all the printing, and wait for the master branch to settle, and then do the "unsigned long" -> size_t conversion. That will probably happen after 2.20.

At the moment, the big "unsigned long" -> size_t conversion is dependend on
 - mk/use-size-t-in-zlib
 - sb/more-repo-in-api,
 - jk/xdiff-interface'
 (and probably more stuff from Duy and others)

How should we handle the big makeover ?

> -Peff

And thanks for reading my stuff