git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] fix pull/merge --verify-signature on an unborn branch

From
Jeff King <peff@peff.net>
Date
Nov 6, 2018, 07:49 UTC
Message-ID
<20181106074910.GA31978@sigill.intra.peff.net>

This bug was reported to the private security list, but I don't think it's easily exploitable, since merging or pulling into an unborn branch is pretty uncommon.

The root of the issue in both commands is just that we handle unborn branches in a special code path that never learned about --verify-signatures.

  [1/3]: merge: extract verify_merge_signature() helper
  [2/3]: merge: handle --verify-signatures for unborn branch
  [3/3]: pull: handle --verify-signatures for unborn branch
 builtin/merge.c                    | 30 +++++-------------------------
 builtin/pull.c                     | 11 +++++++++++
 commit.c                           | 26 ++++++++++++++++++++++++++
 commit.h                           |  7 +++++++
 t/t5573-pull-verify-signatures.sh  |  7 +++++++
 t/t7612-merge-verify-signatures.sh |  7 +++++++
 6 files changed, 63 insertions(+), 25 deletions(-)
-Peff
Next: Jeff King
Message 1 of 4 in “fix pull/merge --verify-signature on an unborn branch”
  1. 0/3 fix pull/merge --verify-signature on an unborn branchJeff King, Nov 6, 2018
  2. 1/3 merge: extract verify_merge_signature() helperJeff King, Nov 6, 2018
  3. 2/3 merge: handle --verify-signatures for unborn branchJeff King, Nov 6, 2018
  4. 3/3 pull: handle --verify-signatures for unborn branchJeff King, Nov 6, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.