Re: [PATCH] it's called read_object_file() these days

From: Jeff King <peff@peff.net>
Date: Nov 2, 2018, 06:24 UTC
Message-ID: <20181102062429.GA29939@sigill.intra.peff.net>
In-Reply-To: <xmqqpnvoovzk.fsf@gitster-ct.c.googlers.com>

On Fri, Nov 02, 2018 at 03:05:03PM +0900, Junio C Hamano wrote:

> Remnant of the old name of the function still remains in comments.
> Update them all.

Yay. What's here looks obviously correct.

Show 9 quoted lines

> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>  apply.c       | 2 +-
>  builtin/gc.c  | 2 +-
>  fast-import.c | 4 ++--
>  notes.c       | 2 +-
>  object.h      | 2 +-
>  sha1-file.c   | 2 +-
>  6 files changed, 7 insertions(+), 7 deletions(-)

There's another mention in Documentation/technical/api-object-access.txt.

But since the entire API is undocumented, I'm not sure it matters much. That file has been a placeholder since 2007. Maybe we should just delete it; its existence does not seem to be guilting anyone into documenting, and these days we'd prefer to do it in-header anyway.

-Peff