[PATCH 20/24] submodule: don't add submodule as odb for push

From: Stefan Beller <sbeller@google.com>
Date: Oct 30, 2018, 22:08 UTC
Message-ID: <20181030220817.61691-21-sbeller@google.com>
In-Reply-To: <20181030220817.61691-1-sbeller@google.com>

In push_submodule(), because we do not actually need access to objects in the submodule, do not invoke add_submodule_odb(). (for_each_remote_ref_submodule() does not require access to those objects, and the actual push is done by spawning another process, which handles object access by itself.)

This code of push_submodule() is exercised in t5531 and continues to work, showing that the submodule odbc is not needed.

Signed-off-by: Stefan Beller <sbeller@google.com>
---
 submodule.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/submodule.c b/submodule.c
index 0fdda45252..da1ac1e6f8 100644
--- a/submodule.c
+++ b/submodule.c
@@ -1024,9 +1024,6 @@ static int push_submodule(const char *path,
 			  const struct string_list *push_options,
 			  int dry_run)
 {
-	if (add_submodule_odb(path))
-		return 1;
-
 	if (for_each_remote_ref_submodule(path, has_remote, NULL) > 0) {
 		struct child_process cp = CHILD_PROCESS_INIT;
 		argv_array_push(&cp.args, "push");

-- 
2.19.1.930.g4563a0d9d0-goog